Merge branch 'fog_patches' of https://github.com/kickstarter/paperclip

lib/paperclip/storage/fog.rb

@@ -45,6 +45,7 @@ module Paperclip
           @fog_credentials  = @options[:fog_credentials]
           @fog_credentials  = @options[:fog_credentials]
           @fog_host         = @options[:fog_host]
           @fog_host         = @options[:fog_host]
           @fog_public       = @options[:fog_public]
           @fog_public       = @options[:fog_public]
+          @fog_file         = @options[:fog_file] || {}
 
 
           @url = ':fog_public_url'
           @url = ':fog_public_url'
           Paperclip.interpolates(:fog_public_url) do |attachment, style|
           Paperclip.interpolates(:fog_public_url) do |attachment, style|
@@ -64,11 +65,19 @@ module Paperclip
       def flush_writes
       def flush_writes
         for style, file in @queued_for_write do
         for style, file in @queued_for_write do
           log("saving #{path(style)}")
           log("saving #{path(style)}")
-          directory.files.create(
+          retried = false
+          begin
+            directory.files.create(@fog_file.merge(
               :body   => file,
               :body   => file,
               :key    => path(style),
               :key    => path(style),
               :public => @fog_public
               :public => @fog_public
-          )
+            ))
+          rescue Excon::Errors::NotFound
+            raise if retried
+            retried = true
+            directory.save
+            retry
+          end
         end
         end
         @queued_for_write = {}
         @queued_for_write = {}
       end
       end
@@ -115,12 +124,7 @@ module Paperclip
       end
       end
 
 
       def directory
       def directory
-        @directory ||= begin
-          connection.directories.get(@fog_directory) || connection.directories.create(
-            :key => @fog_directory,
-            :public => @fog_public
-          )
-        end
+        @directory ||= connection.directories.new(:key => @fog_directory)
       end
       end
 
 
     end
     end

test/fog_test.rb

@@ -16,15 +16,21 @@ class FogTest < Test::Unit::TestCase
       }
       }
 
 
       @connection = Fog::Storage.new(@credentials)
       @connection = Fog::Storage.new(@credentials)
+      @connection.directories.create(
+        :key => @fog_directory
+      )
 
 
-      rebuild_model(
+      @options = {
         :fog_directory    => @fog_directory,
         :fog_directory    => @fog_directory,
         :fog_credentials  => @credentials,
         :fog_credentials  => @credentials,
         :fog_host         => nil,
         :fog_host         => nil,
         :fog_public       => true,
         :fog_public       => true,
+        :fog_file         => {:cache_control => 1234},
         :path             => ":attachment/:basename.:extension",
         :path             => ":attachment/:basename.:extension",
         :storage          => :fog
         :storage          => :fog
-      )
+      }
+
+      rebuild_model(@options)
     end
     end
 
 
     should "be extended by the Fog module" do
     should "be extended by the Fog module" do
@@ -46,16 +52,17 @@ class FogTest < Test::Unit::TestCase
       end
       end
 
 
       context "without a bucket" do
       context "without a bucket" do
-        should "succeed" do
+        setup do
+          @connection.directories.get(@fog_directory).destroy
+        end
+
+        should "create the bucket" do
           assert @dummy.save
           assert @dummy.save
+          assert @connection.directories.get(@fog_directory)
         end
         end
       end
       end
 
 
       context "with a bucket" do
       context "with a bucket" do
-        setup do
-          @connection.directories.create(:key => @fog_directory)
-        end
-
         should "succeed" do
         should "succeed" do
           assert @dummy.save
           assert @dummy.save
         end
         end
@@ -63,14 +70,7 @@ class FogTest < Test::Unit::TestCase
 
 
       context "without a fog_host" do
       context "without a fog_host" do
         setup do
         setup do
-          rebuild_model(
-            :fog_directory    => @fog_directory,
-            :fog_credentials  => @credentials,
-            :fog_host         => nil,
-            :fog_public       => true,
-            :path             => ":attachment/:basename.:extension",
-            :storage          => :fog
-          )
+          rebuild_model(@options.merge(:fog_host => nil))
           @dummy = Dummy.new
           @dummy = Dummy.new
           @dummy.avatar = StringIO.new('.')
           @dummy.avatar = StringIO.new('.')
           @dummy.save
           @dummy.save
@@ -83,14 +83,7 @@ class FogTest < Test::Unit::TestCase
 
 
       context "with a fog_host" do
       context "with a fog_host" do
         setup do
         setup do
-          rebuild_model(
-            :fog_directory    => @fog_directory,
-            :fog_credentials  => @credentials,
-            :fog_host         => 'http://example.com',
-            :fog_public       => true,
-            :path             => ":attachment/:basename.:extension",
-            :storage          => :fog
-          )
+          rebuild_model(@options.merge(:fog_host => 'http://example.com'))
           @dummy = Dummy.new
           @dummy = Dummy.new
           @dummy.avatar = StringIO.new('.')
           @dummy.avatar = StringIO.new('.')
           @dummy.save
           @dummy.save