Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
paperclip
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
ikcrm_common
paperclip
Commits
14fb7698
Commit
14fb7698
authored
Jun 09, 2008
by
Rolf Bjaanes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
added sanitizing of filenames
parent
edfff2fb
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
28 additions
and
1 deletions
+28
-1
lib/paperclip/attachment.rb
+1
-1
test/test_attachment.rb
+27
-0
No files found.
lib/paperclip/attachment.rb
View file @
14fb7698
...
...
@@ -58,7 +58,7 @@ module Paperclip
return
nil
if
uploaded_file
.
nil?
@queued_for_write
[
:original
]
=
uploaded_file
.
to_tempfile
@instance
[
:"
#{
@name
}
_file_name"
]
=
uploaded_file
.
original_filename
.
strip
@instance
[
:"
#{
@name
}
_file_name"
]
=
uploaded_file
.
original_filename
.
strip
.
gsub
/[^A-Za-z0-9\.]/
,
'_'
@instance
[
:"
#{
@name
}
_content_type"
]
=
uploaded_file
.
content_type
.
strip
@instance
[
:"
#{
@name
}
_file_size"
]
=
uploaded_file
.
size
.
to_i
...
...
test/test_attachment.rb
View file @
14fb7698
...
...
@@ -113,6 +113,33 @@ class AttachmentTest < Test::Unit::TestCase
should
"strip whitespace from content_type field"
do
assert_equal
"image/png"
,
@dummy
.
avatar
.
instance
.
avatar_content_type
end
end
context
"Attachment with strange letters"
do
setup
do
rebuild_model
@not_file
=
mock
@not_file
.
stubs
(
:nil?
).
returns
(
false
)
@not_file
.
expects
(
:to_tempfile
).
returns
(
self
)
@not_file
.
expects
(
:original_filename
).
returns
(
"sheep_say_bæ.png
\r\n
"
)
@not_file
.
expects
(
:content_type
).
returns
(
"image/png
\r\n
"
)
@not_file
.
expects
(
:size
).
returns
(
10
)
@dummy
=
Dummy
.
new
@attachment
=
@dummy
.
avatar
@attachment
.
expects
(
:valid_assignment?
).
with
(
@not_file
).
returns
(
true
)
@attachment
.
expects
(
:queue_existing_for_delete
)
@attachment
.
expects
(
:post_process
)
@attachment
.
expects
(
:validate
)
@dummy
.
avatar
=
@not_file
end
should
"remove strange letters and replace with underscore (_)"
do
assert_equal
"sheep_say_b__.png"
,
@dummy
.
avatar
.
original_filename
end
end
context
"An attachment"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment