Commit a46adc86 by Pedro Moreira

Correct failing S3 storage spec

This is part of the effort started at https://github.com/thoughtbot/paperclip/issues/2199)
to ensure the test suite is green locally.

This spec was failing on obtaining a S3 instance with an `nil` region
key. Since `Aws::Resource` does a regex match against the region key
passed in, we would fail on `NoMethodError`.

This corrects the issue by setting a region key to an empty string in
the test setup.
parent dfd73b3e
...@@ -672,7 +672,9 @@ describe Paperclip::Storage::S3 do ...@@ -672,7 +672,9 @@ describe Paperclip::Storage::S3 do
s3_host_name: "s3-world-end.amazonaws.com" }, s3_host_name: "s3-world-end.amazonaws.com" },
development: { development: {
s3_region: "ap-northeast-1", s3_region: "ap-northeast-1",
s3_host_name: "s3-ap-northeast-1.amazonaws.com" } s3_host_name: "s3-ap-northeast-1.amazonaws.com" },
test: {
s3_region: "" }
} }
@dummy = Dummy.new @dummy = Dummy.new
end end
...@@ -1578,5 +1580,4 @@ describe Paperclip::Storage::S3 do ...@@ -1578,5 +1580,4 @@ describe Paperclip::Storage::S3 do
Rails.env = stored_env Rails.env = stored_env
end end
end end
end end
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment