Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
paperclip
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
ikcrm_common
paperclip
Commits
fa763d63
Commit
fa763d63
authored
Apr 30, 2016
by
Tute Costa
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2184 from danmakenoise/master
Clarifying contributions.
parents
087d8a76
a2e2e99a
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
7 deletions
+12
-7
CONTRIBUTING.md
+8
-5
README.md
+1
-1
lib/paperclip/errors.rb
+3
-1
No files found.
CONTRIBUTING.md
View file @
fa763d63
...
...
@@ -10,19 +10,22 @@ Here's a quick guide for contributing:
1.
Fork the repo.
2.
Run the tests. We only take pull requests with passing tests, and it's great
1.
Make sure you have ImageMagick and Ghostscript installed. See
[
this section
]
(./README.md#image-processor) of the README.
1.
Run the tests. We only take pull requests with passing tests, and it's great
to know that you have a clean slate:
`bundle && bundle exec rake`
3
.
Add a test for your change. Only refactoring and documentation changes
1
.
Add a test for your change. Only refactoring and documentation changes
require no new tests. If you are adding functionality or fixing a bug, we need
a test!
4
.
Make the test pass.
1
.
Make the test pass.
5
.
Mention how your changes affect the project to other developers and users in
1
.
Mention how your changes affect the project to other developers and users in
the
`NEWS.md`
file.
6
.
Push to your fork and submit a pull request.
1
.
Push to your fork and submit a pull request.
At this point you're waiting on us. We like to at least comment on, if not
accept, pull requests within seven business days (most of the work on Paperclip
...
...
README.md
View file @
fa763d63
...
...
@@ -955,7 +955,7 @@ guidelines:
about writing tests for paperclip, please open a
[
GitHub issue
](
https://github.com/thoughtbot/paperclip/issues/new
)
.
Please see
`CONTRIBUTING.md`
for more details on contributing and running test.
Please see
[
`CONTRIBUTING.md`
](
./CONTRIBUTING.md
)
for more details on contributing and running test.
Thank you to all
[
the contributors
](
https://github.com/thoughtbot/paperclip/graphs/contributors
)
!
...
...
lib/paperclip/errors.rb
View file @
fa763d63
...
...
@@ -19,7 +19,9 @@ module Paperclip
end
# Will be thrown when ImageMagic cannot determine the uploaded file's
# metadata, usually this would mean the file is not an image.
# metadata, usually this would mean the file is not an image. If you are
# consistently receiving this error on PDFs make sure that you have
# installed Ghostscript.
class
NotIdentifiedByImageMagickError
<
Paperclip
::
Error
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment