- 19 Aug, 2016 2 commits
-
-
If `only_process` list is not empty, but it doesn't contain `:original` style, original file hasn't been reprocessed and it's not needed to rewrite/reupload it. [fixes #1993] [fixes #2046] [fixes #1804]
Aleksandr Zykov committed -
Documentation update for thoughtbot/paperclip#2217. [These lines](https://github.com/thoughtbot/paperclip/blob/95acf3b898bd782f4429d42fd2d8812505390328/lib/paperclip/storage/s3.rb#L101-L112) in the documentation indicated that the value for the `s3_storage_class` configuration option should be `:reduced_redundancy`. However, using this value with Paperclip 5.0.0 results in a `Aws::S3::Errors::InvalidStorageClass` error with the message `The storage class you specified is not valid`. The [documentation for the `Aws::S3::Object#storage_class` method](http://docs.aws.amazon.com/sdkforruby/api/Aws/S3/Object.html#storage_class-instance_method) in the `aws-sdk` gem documentation indicates that the correct value is now `REDUCED_REDUNDANCY` (along with a few other potential values).
Cody Robbins committed
-
- 17 Aug, 2016 1 commit
-
-
There's a subtle difference between what `\Z` and `\z` consider the "end of string" which is that the uppercase version allows a single trailing newline: ``` /\Afoo\Z/.match("foo\n") /\Afoo\Z/.match("foo\n\n") /\Afoo\z/.match("foo\n") ```
Ben Pickles committed
-
- 16 Aug, 2016 1 commit
-
-
* There is no need to pass options argument to UrlGenerator * Houndci compliance
Alexey Pokhozhaev committed
-
- 03 Aug, 2016 1 commit
-
-
I recently implemented a custom processor that used the Exifr gem to extract EXIF information from images uploaded to a Paperclip attachment. Exifr's processor uses readbyte to parse the EXIF header, so it hit errors when Paperclip's File-like object didn't have one. There's also a test for this delegation. I've also tidied up the README documentation for custom processors, hopefully to be more clear than before. There was some duplicated content between the "Post Processing" section and the "Custom Attachment Processing" section, and those sections were separated in the file. I've dedicated the "Post Processing" section to Paperclip's built in thumbnailing processors, and made "Custom Attachment Processing" section solely about writing & using your own custom processors. This should be a more understandable progression, as built-in functionality is discussed first & separately from extending Paperclip.k
Alex Pounds committed
-
- 23 Jul, 2016 1 commit
-
-
- The uri io adapter now seeks for the content-disposition header if this is pressent the value filename is taken instead of the last path segment for the resource file name - Fix style comments - Applied the Tute Costa refactor to URI Adapter. - Added entry to the NEWS file. - Removed editor tracking file - Fix test cases
Jonathan Garay committed
-
- 01 Jul, 2016 1 commit
-
-
Update NEWS file. [ci skip]
Tute Costa committed
-
- 16 Jun, 2016 1 commit
-
-
* Add `read_timeout` option to `UriAdapter#download_content` method * Default `read_timeout` is `nil` * Update NEWS
Sergey Novikov committed
-
- 14 Jun, 2016 1 commit
-
-
* replaced if-not-blank with if-present an instance of code was testing presence via `!a.blank?`. this is now replaced with a more readable version: `a.present?` * replaced 2 if-not-blank checks with if-present checks * temporarily restrict travis * reverted travis changes * readded whitespace
S. Humza Shah committed
-
- 24 May, 2016 1 commit
-
-
When a matcher uses both `allowing` and `rejecting`, and validation fails, `@missing_rejected_types` might still be `nil`. When a matcher only uses either of the two, a part of the message is `nil`.
Emil Sågfors committed
-
- 10 May, 2016 1 commit
-
-
[fixes #2016]
Tute Costa committed
-
- 09 May, 2016 1 commit
-
-
[fixes #1932]
Piotr Szal committed
-
- 05 May, 2016 1 commit
-
-
This was really confusing to me, and I think this small change would help to clarify what's going on without having to trace through the code.
Cameron Finucane committed
-
- 30 Apr, 2016 3 commits
-
-
Dan Phillips committed
-
Fixes #2130.
Ralin Chimev committed -
Fixes #2130.
Ralin Chimev committed
-
- 28 Apr, 2016 1 commit
-
-
Currently paperclip fails with `NoMethodError` on `nil` when file is not present. Since `nil` is proper response from fog on missing files, and this method already returns `false` if any error happen (see line 178), returning `false` here would be properly handled on client code. [closes #2173]
Mark Guk committed
-
- 12 Apr, 2016 2 commits
-
-
Update NEWS. [ci skip]
Tute Costa committed -
Adds failing spec to command line dup check [fixes #1670] [fixes #2169]
Christophe Chong committed
-
- 30 Mar, 2016 1 commit
-
-
`Paperclip::Storage::Fog#host_name_for_directory` assumes a String-like object is set and doesn't check if `@options[:fog_directory]` is callable, while `Paperclip::Storage::Fog#directory` does. This extracts a new method with the condition and refactors the other two methods to call it. Fixes #2018, #2093.
Thomas Ingram committed
-
- 24 Mar, 2016 5 commits
-
-
This configuration constant was useful for supporting different versions of AWS SDK. We don't any longer, and we can set the value directly. [fixes #2148]
Tute Costa committed -
* `AWS::Core` is an AWS SDK v1 API, we can drop it * We don't use the "I attach a" cucumber step
Tute Costa committed -
Brings back warning on not supported SDK versions. Related: https://github.com/thoughtbot/paperclip/commit/25be0b25d67923e28419c6146e8f8307741a974b#commitcomment-16831800
Tute Costa committed -
We don't support AWS SDK v1 any longer.
Tute Costa committed -
Drops Rails 3 branches. [fixes #2101]
Lucas Caton committed
-
- 23 Mar, 2016 5 commits
-
-
Rails 3 is not supported anymore. We can safely remove mentions and snippets for it. Drop unused variable definition (`options`).
Tute Costa committed -
Update NEWS. [fixes #2134] [ci skip]
ycohn committed -
Ref: https://github.com/rails/rails/commit/2386daabe7f8c979b453010dc0de3e1f6bbf859d Specifically: > Chains of callbacks defined **with** a `:terminator` option will > maintain their existing behavior of halting as soon as a `before_` > callback matches the terminator's expectation. For instance, > ActiveModel's callbacks will still halt the chain when a `before_` > callback returns `false`. In terminator callbacks, the `result` value changed to be a lambda now. This change reflects that, updating the terminator to compare the result of the block to `false`. Also: * Removes Rails 4.1 branch (we don't support it anymore) * Rewrite for legibility: change `unless` for `if`
Tute Costa committed -
- Also bump Travis Ruby 2.2.x version to 2.2.4
maclover7 committed -
We found that uploading large files to S3 would result in a socket error ("connection reset by peer") occasionally and lately much more consistently. In researching this I saw that many people got this error when uploading too large of a file without multipart chunking. I would have assumed fog did this automatically but the default chunk size may be too high. In order to address this I wanted to drop the chunk size to 100MB. Rather than hard-code this I opted to expose a `fog_option` configuration option that lets me pass any additional options I want to the fog's `#create` call. This is similar to the `fog_attributes` option implemented in CarrierWave which [addresses the same problem](http://stackoverflow.com/a/11867978/201911). We've been running this now for a week in production and it seems to resolve the issue. https://github.com/thoughtbot/paperclip/pull/2135
Jeremy Wadsack committed
-
- 15 Jan, 2016 1 commit
-
-
The MD5 sum of an attachment is only necessary if the model has a corresponding _fingerprint column. If this column is absent, there is no need to calculate the MD5, which can be an expensive operation for large files. Accomplish this by deferring the fingerprint calculation using a block. If the _fingerprint column is absent, the block is never called, and the calculation is avoided.
Matt Brictson committed
-
- 02 Jan, 2016 1 commit
-
-
These variables were introduced in: https://github.com/thoughtbot/paperclip/commit/6ea7c26512434a but their usage were canceled in: https://github.com/thoughtbot/paperclip/commit/c740fb171fe
Marek L committed
-
- 22 Dec, 2015 1 commit
-
-
Tute Costa committed
-
- 02 Dec, 2015 2 commits
-
-
Extract another repository only concerned with locales: https://github.com/thoughtbot/paperclip-i18n A user of paperclip might choose to add `paperclip-i18n` as a dependency for their application, or copy over the related locale file into their project. This is a first step in splitting some parts of the codebase into other projects. Simple and relevant contributions like new translations might get lost in the shuffle of dozens of PRs awaiting for approval, that take time to review and merge. Locales are a simple enough problem to be handled in an external repository, where tests for consistency across translations run in less than a second, and PRs can almost trivially be merged in.
Tute Costa committed -
Andy Stewart committed
-
- 21 Nov, 2015 1 commit
-
-
Airton Sampaio de Sobral committed
-
- 19 Nov, 2015 1 commit
-
-
Dave Gynn committed
-
- 15 Nov, 2015 3 commits