- 12 Apr, 2019 2 commits
-
-
James Watling committed
-
I believe this is meant to be "does not", not "does".
Matt Wright committed
-
- 25 Nov, 2018 1 commit
-
-
The official [RSpec documentation](https://relishapp.com/rspec/rspec-expectations/v/2-4/docs/custom-matchers/define-matcher#define-a-matcher-with-default-messages) outlines that the main block when defining custom matchers should be called `match`. The documentation currently uses `matches` when giving an example of the custom `:have_attached_file` matcher, which leads to the error NoMethodError: undefined method `matches' for #<Class:#<RSpec::Matchers::DSL::Matcher:0x00007fc898c846d8>> Updating to `match`
abhchand committed
-
- 09 Nov, 2018 1 commit
-
-
Meant to catch this in the prior commit: `key` is a SQL reserved word and therefore must have backticks around it.
Mike Burns committed
-
- 31 Oct, 2018 1 commit
-
-
Paul M. Thiebauth committed
-
- 26 Oct, 2018 1 commit
-
-
This is a combination of [a comment from @sankage] and [a gist by @colinpetruno]. Many thanks to them for sharing their discoveries. [a comment from @sankage]: https://github.com/thoughtbot/paperclip/pull/2568#issuecomment-381629629 [a gist by @colinpetruno]: https://gist.github.com/colinpetruno/037de4fafa4cff695b1d7905cd6fd7c2
Mike Burns committed
-
- 05 Oct, 2018 1 commit
-
-
Explain some lessons learned from successfully migrating an application from Paperclip to ActiveStorage. Replace links to `master` or `edgeguides.rubyonrails.org` with versions locked to `v5.2`.
Sean Doyle committed
-
- 13 Sep, 2018 1 commit
-
-
Zane Wolfgang Pickett committed
-
- 27 Jul, 2018 4 commits
-
-
Mike Burns committed
-
As before: use `#sql_type` instead of `#type` in the tests. The `#type` is the category -- string, integer, datetime -- but the `#sql_type` is the storage specifics -- `TEXT`, `VARCHAR`, `BIGINT`, `DATE. Switch to the `#sql_type` so we can be sure it's being stored correctly.
Mike Burns committed -
The 4 byte limit is starting to wrap around; some complaints are being seen online, e.g. https://stackoverflow.com/questions/34477248/rails-paperclip-rangeerror/47999887#47999887 . Use `#sql_type` instead of `#type` in the tests. The `#type` is the category -- string, integer, datetime -- but the `#sql_type` is the storage specifics -- `TEXT`, `VARCHAR`, `BIGINT`, `DATE. Switch to the `#sql_type` so we can be sure it's being stored correctly.
Alen Zamanyan committed -
In an effort to avoid filling $TMPDIR with stray files, let's close all Tempfiles after we are done with them. Additionally, add an around-filter to each test in the integration suite to catch cases where we don't do this. This exposes issues around re-processing a subset of our attached files: it leaves Tempfiles around. Mark that test as skipped (with a detailed explanation) because we cannot figure out how to make it work. Related to #1326.
Erkki Eilonen committed
-
- 25 May, 2018 16 commits
-
-
As described in #2118, `OpenURI::Meta#content_type` will return `application/octet-stream` when no `content-type` header is set. Using the original `meta` fixes this issue.
Jean-Philippe Doyle committed -
While using the Paperclip gem, we noticed during some ad-hoc testing that if you do not supply an extension when uploading a file, Paperclip effectively skipped it's spoofing check, which allowed potentially dangerous files to slip through into your application. This addresses that by moving the checks around a little bit and only testing against the extension when there is one.
George Walters II committed -
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
This validation was causing issue when there is no content_type column in the database, as the content type of the attachment would be empty. There should be no need to check attachment's validity because this `#reprocess!` method is running internally on the server. Fix #2078
Amanda Munoz and Prem Sichanugrist committed
-
- 18 May, 2018 8 commits
-
-
Encountered an issue where the URI was returning header with content-disposition where the filename value wasn't enclosed in the double quotes. Turns out that this is a valid grammar according to RFC6266. Also made the logic more robust to account for spaces and uppercase letters.
Yves Riel committed -
e.g., the way google stores its user profile photos (from their oauth2 API) https://lh3.googleusercontent.com/-aRHQV4YjnBM/AAAAAAAAAAI/AAAAAAAAAAo/ngSjy9-yR5c/photo.jpg
Hasan Kumar committed -
Since the support version is Ruby 2.0 or later, magic comment is unnecessary. > The UTF-8 default encoding, which make many magic comments omissible https://www.ruby-lang.org/en/news/2013/02/24/ruby-2-0-0-p0-is-released/
hash52 committed -
This cause to erease previous image when the id change to above `999_999_999`, for example: ``` 2.3.6 :010 > id => 1000602578 2.3.6 :011 > ("%09d".freeze % id).scan(/\d{3}/).join("/".freeze) => "100/060/257" ```
Laurent Arnoud committed -
kylekeesling committed
-
Mike Burns committed
-
Horacio Chávez committed
-
"key" is a reserved keyword in MariaDB, so the SQL statement fails. Surrounding the keyword in backticks fixes the error.
Luke committed
-
- 14 May, 2018 1 commit
-
-
* Add deprecation notice to README Addresses new projects, existing projects, issues, and PRs.
Mike Burns committed
-
- 08 May, 2018 3 commits
-
-
Akihiko Odaki committed
-
Roderick Monje committed
-
So that the `file_system` option renders correctly on the docs
Viki Harrod committed
-