- 27 Jul, 2018 2 commits
-
-
The 4 byte limit is starting to wrap around; some complaints are being seen online, e.g. https://stackoverflow.com/questions/34477248/rails-paperclip-rangeerror/47999887#47999887 . Use `#sql_type` instead of `#type` in the tests. The `#type` is the category -- string, integer, datetime -- but the `#sql_type` is the storage specifics -- `TEXT`, `VARCHAR`, `BIGINT`, `DATE. Switch to the `#sql_type` so we can be sure it's being stored correctly.
Alen Zamanyan committed -
In an effort to avoid filling $TMPDIR with stray files, let's close all Tempfiles after we are done with them. Additionally, add an around-filter to each test in the integration suite to catch cases where we don't do this. This exposes issues around re-processing a subset of our attached files: it leaves Tempfiles around. Mark that test as skipped (with a detailed explanation) because we cannot figure out how to make it work. Related to #1326.
Erkki Eilonen committed
-
- 25 May, 2018 3 commits
-
-
As described in #2118, `OpenURI::Meta#content_type` will return `application/octet-stream` when no `content-type` header is set. Using the original `meta` fixes this issue.
Jean-Philippe Doyle committed -
While using the Paperclip gem, we noticed during some ad-hoc testing that if you do not supply an extension when uploading a file, Paperclip effectively skipped it's spoofing check, which allowed potentially dangerous files to slip through into your application. This addresses that by moving the checks around a little bit and only testing against the extension when there is one.
George Walters II committed -
This validation was causing issue when there is no content_type column in the database, as the content type of the attachment would be empty. There should be no need to check attachment's validity because this `#reprocess!` method is running internally on the server. Fix #2078
Amanda Munoz and Prem Sichanugrist committed
-
- 18 May, 2018 3 commits
-
-
Encountered an issue where the URI was returning header with content-disposition where the filename value wasn't enclosed in the double quotes. Turns out that this is a valid grammar according to RFC6266. Also made the logic more robust to account for spaces and uppercase letters.
Yves Riel committed -
Since the support version is Ruby 2.0 or later, magic comment is unnecessary. > The UTF-8 default encoding, which make many magic comments omissible https://www.ruby-lang.org/en/news/2013/02/24/ruby-2-0-0-p0-is-released/
hash52 committed -
This cause to erease previous image when the id change to above `999_999_999`, for example: ``` 2.3.6 :010 > id => 1000602578 2.3.6 :011 > ("%09d".freeze % id).scan(/\d{3}/).join("/".freeze) => "100/060/257" ```
Laurent Arnoud committed
-
- 08 May, 2018 2 commits
-
-
Akihiko Odaki committed
-
Roderick Monje committed
-
- 07 May, 2018 3 commits
-
-
Closes https://github.com/thoughtbot/paperclip/issues/2253
Roderick Monje committed -
Hayden Ball committed
-
2254 coverage (#2395) * f(x): default to Paperclip::ContentTypeDetector * fix: failures * spec: cover consecutive periods * fix: hound * fix: hound
Roderick Monje committed
-
- 09 Mar, 2018 3 commits
-
-
* Added support for aws-sdk-s3 gem which is now preferred way to interact with s3. Reference: https://github.com/aws/aws-sdk-ruby/blob/master/V3_UPGRADING_GUIDE.md#library-maintainer * Drop support for aws-sdk gem
Wojciech Wnętrzak committed -
Yamagishi Kazutoshi committed
-
There was a bug in the code where if you created a bucket the file would get read but not rewind on the first pass through (when the bucket didn't exist). So when we went into the retry logic the file would already be read and zero bytes would get copied over from the file. This fixes that by rewinding the file during the retry so it gets correctly copied over the second time around.
Nate Holland committed
-
- 02 Mar, 2018 2 commits
-
-
Sid Raval committed
-
Michael Raidel committed
-
- 30 Jan, 2018 1 commit
-
-
Please see #2527 for details.
Clemens Fuchslocher committed
-
- 23 Jan, 2018 1 commit
-
-
Remove the URI adapters. Few people use them by default and they can allow insight into the internal networks of the server. If you want to enable them, add (for example) `Paperclip.DataUriAdapter.register` to your `config/initializers/paperclip.rb` file. This is related to CVE-2017-0889. Elsewhere fix CI: it's `s3.us-west-2` now, with a dot.
Jon Yurek committed
-
- 01 Dec, 2016 1 commit
-
-
Thanks for the tip, @brendon! https://github.com/thoughtbot/paperclip/pull/2331#issuecomment-262910522
Tute Costa committed
-
- 14 Nov, 2016 2 commits
-
-
Jake Faris committed
-
Jake Faris committed
-
- 11 Nov, 2016 1 commit
-
-
Jake Faris committed
-
- 12 Sep, 2016 1 commit
-
-
Johnny Shields committed
-
- 30 Aug, 2016 1 commit
-
-
Allows `s3_host_alias` to be set to CDNs which support S3 Bucket prefix. [fixes #2287]
Carlo Cajucom committed
-
- 28 Aug, 2016 2 commits
-
-
Bug introduced in 1c7d7f66 Per https://github.com/thoughtbot/paperclip/commit/1c7d7f66ceea27cfe604e3a13c2eb87df217d13a#commitcomment-18765681 request
Wojciech Wnętrzak committed -
[Amazon S3 Transfer Acceleration](http://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html) enables fast, easy, and secure transfers of files over long distances between your client and an S3 bucket. And [aws-sdk](https://github.com/aws/aws-sdk-ruby) has allowed us to enable this feature in version 2.3.0 (more detail is [here](https://github.com/aws/aws-sdk-ruby/pull/1163)). You can now pass a configuration option (:use_accelerate_endpoint) when config Paperclip with S3. You can enable the [Amazon S3 Transfer Acceleration](http://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html) by set this option: ```:use_accelerate_endpoint => true``` [fixes #2291]
Dat committed
-
- 24 Aug, 2016 2 commits
-
-
* correct S3 specs to use the correct keys in the s3_credentials hash * S3 tests work with a region that requires s3_domain_url [fixes #1985]
Isaac Betesh committed -
Adapters now accept an options parameter, that currently specifies the type of hash digest to use. The default value remains MD5, but can be specified to be any OpenSSL-supported digest. The specs are modified to reflect that. The task just reassigns all of the attachments, thereby regenerating their fingerprints.
Bart committed
-
- 23 Aug, 2016 1 commit
-
-
[closes #2155]
Jacob Bullock committed
-
- 19 Aug, 2016 3 commits
-
-
* Add default `content_type_detector` to `UploadedFileAdapter`
Roderick Monje committed -
Default `s3_protocol` used to be `http` when `:s3_permissions` are `:public_read` (default), and `https` when `:s3_permissions` are anything else. With an empty String as default, if the page is served over HTTPS, attachment URL will be HTTPS, and if the page is served over HTTP, attachment url will be HTTP. `public-read` is an authorization concept, independent form the encryption of the HTTP connection used to read the file. As such, the one shouldn't define the other. [fixes #2038]
Tute Costa committed -
If `only_process` list is not empty, but it doesn't contain `:original` style, original file hasn't been reprocessed and it's not needed to rewrite/reupload it. [fixes #1993] [fixes #2046] [fixes #1804]
Aleksandr Zykov committed
-
- 17 Aug, 2016 1 commit
-
-
There's a subtle difference between what `\Z` and `\z` consider the "end of string" which is that the uppercase version allows a single trailing newline: ``` /\Afoo\Z/.match("foo\n") /\Afoo\Z/.match("foo\n\n") /\Afoo\z/.match("foo\n") ```
Ben Pickles committed
-
- 16 Aug, 2016 1 commit
-
-
* There is no need to pass options argument to UrlGenerator * Houndci compliance
Alexey Pokhozhaev committed
-
- 03 Aug, 2016 1 commit
-
-
I recently implemented a custom processor that used the Exifr gem to extract EXIF information from images uploaded to a Paperclip attachment. Exifr's processor uses readbyte to parse the EXIF header, so it hit errors when Paperclip's File-like object didn't have one. There's also a test for this delegation. I've also tidied up the README documentation for custom processors, hopefully to be more clear than before. There was some duplicated content between the "Post Processing" section and the "Custom Attachment Processing" section, and those sections were separated in the file. I've dedicated the "Post Processing" section to Paperclip's built in thumbnailing processors, and made "Custom Attachment Processing" section solely about writing & using your own custom processors. This should be a more understandable progression, as built-in functionality is discussed first & separately from extending Paperclip.k
Alex Pounds committed
-
- 23 Jul, 2016 1 commit
-
-
- The uri io adapter now seeks for the content-disposition header if this is pressent the value filename is taken instead of the last path segment for the resource file name - Fix style comments - Applied the Tute Costa refactor to URI Adapter. - Added entry to the NEWS file. - Removed editor tracking file - Fix test cases
Jonathan Garay committed
-
- 08 Jul, 2016 1 commit
-
-
AWS no longer accepts `:aes256` as an encryption value and will raise `Aws::S3::Errors::InvalidArgument` with the message `The encryption method specified is not supported`. It should instead be `"AES256"`. This commit makes no implementation change, but for those that use source code and tests as documentation, it should help prevent confusion.
Nick Rivadeneira committed
-
- 16 Jun, 2016 1 commit
-
-
* Add `read_timeout` option to `UriAdapter#download_content` method * Default `read_timeout` is `nil` * Update NEWS
Sergey Novikov committed
-