- 27 Jul, 2018 3 commits
-
-
Mike Burns committed
-
The 4 byte limit is starting to wrap around; some complaints are being seen online, e.g. https://stackoverflow.com/questions/34477248/rails-paperclip-rangeerror/47999887#47999887 . Use `#sql_type` instead of `#type` in the tests. The `#type` is the category -- string, integer, datetime -- but the `#sql_type` is the storage specifics -- `TEXT`, `VARCHAR`, `BIGINT`, `DATE. Switch to the `#sql_type` so we can be sure it's being stored correctly.
Alen Zamanyan committed -
In an effort to avoid filling $TMPDIR with stray files, let's close all Tempfiles after we are done with them. Additionally, add an around-filter to each test in the integration suite to catch cases where we don't do this. This exposes issues around re-processing a subset of our attached files: it leaves Tempfiles around. Mark that test as skipped (with a detailed explanation) because we cannot figure out how to make it work. Related to #1326.
Erkki Eilonen committed
-
- 25 May, 2018 16 commits
-
-
As described in #2118, `OpenURI::Meta#content_type` will return `application/octet-stream` when no `content-type` header is set. Using the original `meta` fixes this issue.
Jean-Philippe Doyle committed -
While using the Paperclip gem, we noticed during some ad-hoc testing that if you do not supply an extension when uploading a file, Paperclip effectively skipped it's spoofing check, which allowed potentially dangerous files to slip through into your application. This addresses that by moving the checks around a little bit and only testing against the extension when there is one.
George Walters II committed -
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
aboutqx committed
-
This validation was causing issue when there is no content_type column in the database, as the content type of the attachment would be empty. There should be no need to check attachment's validity because this `#reprocess!` method is running internally on the server. Fix #2078
Amanda Munoz and Prem Sichanugrist committed
-
- 18 May, 2018 4 commits
-
-
Encountered an issue where the URI was returning header with content-disposition where the filename value wasn't enclosed in the double quotes. Turns out that this is a valid grammar according to RFC6266. Also made the logic more robust to account for spaces and uppercase letters.
Yves Riel committed -
e.g., the way google stores its user profile photos (from their oauth2 API) https://lh3.googleusercontent.com/-aRHQV4YjnBM/AAAAAAAAAAI/AAAAAAAAAAo/ngSjy9-yR5c/photo.jpg
Hasan Kumar committed -
Since the support version is Ruby 2.0 or later, magic comment is unnecessary. > The UTF-8 default encoding, which make many magic comments omissible https://www.ruby-lang.org/en/news/2013/02/24/ruby-2-0-0-p0-is-released/
hash52 committed -
This cause to erease previous image when the id change to above `999_999_999`, for example: ``` 2.3.6 :010 > id => 1000602578 2.3.6 :011 > ("%09d".freeze % id).scan(/\d{3}/).join("/".freeze) => "100/060/257" ```
Laurent Arnoud committed
-
- 08 May, 2018 2 commits
-
-
Akihiko Odaki committed
-
So that the `file_system` option renders correctly on the docs
Viki Harrod committed
-
- 07 May, 2018 3 commits
-
-
Abhishek Kanojia committed
-
Closes https://github.com/thoughtbot/paperclip/issues/2253
Roderick Monje committed -
Hayden Ball committed
-
- 09 Mar, 2018 5 commits
-
-
[ci skip]
Sid Raval committed -
* Added support for aws-sdk-s3 gem which is now preferred way to interact with s3. Reference: https://github.com/aws/aws-sdk-ruby/blob/master/V3_UPGRADING_GUIDE.md#library-maintainer * Drop support for aws-sdk gem
Wojciech Wnętrzak committed -
[ci skip]
Sid Raval committed -
Yamagishi Kazutoshi committed
-
There was a bug in the code where if you created a bucket the file would get read but not rewind on the first pass through (when the bucket didn't exist). So when we went into the retry logic the file would already be read and zero bytes would get copied over from the file. This fixes that by rewinding the file during the retry so it gets correctly copied over the second time around.
Nate Holland committed
-
- 02 Mar, 2018 3 commits
-
-
Michael Raidel committed
-
Kevin G committed
-
Kevin G committed
-
- 30 Jan, 2018 4 commits
-
-
Please see #2527 for details.
Clemens Fuchslocher committed -
Ivan Stana committed
-
* Provide example for s3_host_name Gives an example, since not everyone knows the format required. * Shorten line per Hound comment
Jonathan Chen committed -
* Add migration_version variable to migration generator for rails 5 compatibility * Update syntax to satisfy hound
Jack Ellenberger committed
-